fix: Explicitly set row and column start and end in Overlap CSS #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpens
changed the title
VincentSmedinga
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
The Overlap CSS currently uses
grid-area: 1 / -1. This is a shorthand forgrid-row-start: 1grid-column-start: -1.This PR changes that to
grid-row/grid-column1 / -1.Why
I don't think
grid-row-start: 1grid-column-start: -1says what we want to say. We want all Overlap children to start on the first row / column and end on the last row / column.Functionally it doesn't matter, because there usually only is 1 row and 1 column. A user could put a
Grid.Cellor something in Overlap though, which would create more rows / columns.How
By changing the CSS.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary: